Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSDF document and fixed document list logic #4320

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

randywoods
Copy link
Collaborator

Made the document list logic a bit more bulletproof. If a filename or title have any trailing spaces, the list builder thought it was a new document and created a new entry in the list. It should now recognize multiple links for the same document and format them as a comma-delimited list after the document name.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Made the document list a bit more bulletproof.  If a filename or title have any trailing spaces, the list builder thought it was a new document and created a new entry in the list.
@LaddieZeigler LaddieZeigler merged commit 73aa2c2 into develop Jan 6, 2025
2 checks passed
@LaddieZeigler LaddieZeigler deleted the feature/CSET-2943 branch January 6, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants